mahara-contributors team mailing list archive

[Rich Trott <670546@xxxxxxxxxxxxxxxxxx>]

It looks like this bug was introduced by the commit done to fix bug
#653839.  https://bugs.launchpad.net/mahara/+bug/653839

That patch removed code that does a very similar thing that the patch I
submitted here does, except that code produces errors/warnings because
it tries to use get_class on a variable that may or may not be an
object.  The patch I submitted uses instanceof, so it doesn't generate
errors/warnings if the variable turns out to be an array rather than an
object.

Perhaps a hybrid of my patch and the original code would be best?
Attached.


** Patch added: "0001-validate_config_options-needs-to-handle-Pieform-obje.patch"
   https://bugs.launchpad.net/mahara/+bug/670546/+attachment/1767984/+files/0001-validate_config_options-needs-to-handle-Pieform-obje.patch

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/670546

Title:
  auth saml config form does not work

Status in Mahara ePortfolio:
  New

Bug description:
  Trying to use the config form for the auth:saml plugin/extension results in the form submission hanging and this appears in the error log:

PHP Fatal error:  Cannot use object of type Pieform as array in /web/mahara/htdocs/auth/saml/lib.php on line 461, referer: https://example.com/admin/extensions/pluginconfig.php?plugintype=auth&pluginname=saml

I'm using a checkout of the current Master branch, 1.4.0dev.  This problem does not appear to be in the release branches.  I'm running Linux (RedHat CentOS 5) + Postgres.