mahara-contributors team mailing list archive

[François Marier <francois@xxxxxxxxxx>]

> Do we need additional param to look into mahara.php file?

No, it looks there by default. See the attached test.php (put it in
htdocs/ and then browse to it).

I'm not sure what's going on here. Are you sure that's where the
untranslated message comes from?

For example, you could hack that file and see if you see the hacked
version in emails:

diff --git a/htdocs/lib/user.php b/htdocs/lib/user.php
index 839b5b6..89ebaf9 100644
--- a/htdocs/lib/user.php
+++ b/htdocs/lib/user.php
@@ -361,9 +361,9 @@ function email_user($userto, $userfrom, $subject, $messagetext, $messagehtml='',
         $mail->From = get_config('noreplyaddress');
         $mail->FromName = (isset($userfrom->id)) ? display_name($userfrom, $userto) : get_config('sitename');
         $customheaders[] = 'Precedence: Bulk'; // Try to avoid pesky out of office responses
-        $messagetext .= "\n\n" . get_string('pleasedonotreplytothismessage') . "\n";
+        $messagetext .= "\n\n" . '***TEST1***' . "\n";
         if ($messagehtml) {
-            $messagehtml .= "\n\n<p>" . get_string('pleasedonotreplytothismessage') . "</p>\n";
+            $messagehtml .= "\n\n<p>" . '***TEST2***' . "</p>\n";
         }
     }
     else {

** Attachment added: "Test script which shows that get_string() works as expected"
   https://bugs.launchpad.net/mahara/+bug/726051/+attachment/1875808/+files/test.php

** Changed in: mahara
       Status: New => Incomplete

** Changed in: mahara
   Importance: Undecided => Low

** Changed in: mahara
    Milestone: None => 1.4.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/726051

Title:
  user.php does not use get_string () stuff

Status in Mahara ePortfolio:
  Incomplete

Bug description:
  Hi,

  I think the following code snippet from /lib/user.php

         $mail->From = get_config('noreplyaddress');
          $mail->FromName = (isset($userfrom->id)) ? display_name($userfrom, $userto) : get_config('sitename');
          $customheaders[] = 'Precedence: Bulk'; // Try to avoid pesky out of office responses
          $messagetext .= "\n\n" . get_string('pleasedonotreplytothismessage') . "\n";
          if ($messagehtml) {
              $messagehtml .= "\n\n<p>" . get_string('pleasedonotreplytothismessage') . "</p>\n";
          }

  does not use the "pleasedonotreplytothismessage" var in
  /lang/mahara.php It's translated but mails show always the English
  text

  Do we need additional param to look into mahara.php file?

  Cheers
  Heinz