mahara-contributors team mailing list archive

[Richard Mansfield <712904@xxxxxxxxxxxxxxxxxx>]

>From the more detailed description on the duplicate bug #632426, it
sounds like this problem can be fixed by changing the private properties
on the PluginImport base class to protected.

This was done in 1.2.7 by commit
739a82a4bf13020dec7182e630a84ab805b5cbcd

1.3 and master already use protected variables in PluginImport, so I'm
going to assume this bug is now fixed.

** Changed in: mahara
       Status: Triaged => Fix Released

** Changed in: mahara
    Milestone: 1.4.0 => None

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/712904

Title:
  property_exists() returns False for private properties

Status in Mahara ePortfolio:
  Fix Released

Bug description:
  From IRC:

  <DonDadda> hi Guys, I have an issue with LEAP2A import. This is an import from 1.2.6 back into 1.2.6
   Is the email address issue responsible for this? http://mahara.org/interaction/forum/topic.php?id=2623
   Going to continue digging

  <DonDadda> Hey: Just a quick side note.
   ith Mahara 1.2.6 implemented in the following environments <= PHP 5.3.2, this function bool property_exists() fails for private properties in base classes. Returning false when true.
   With Mahara 1.2.6 implemented in the following environments <= PHP 5.3.2, this function bool property_exists() fails for private properties in base classes. Returning false when true.
   Changing the classes privately declared properties to public resolved this issue.

  There is also a comment to that effect on bug #576026.

  We should make sure that this is fixed in 1.4 (and probably in 1.3 as
  well).