← Back to team overview

mahara-contributors team mailing list archive

[Bug 771598] Re: Session key validation not working in pieforms

 

** Changed in: mahara
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/771598

Title:
  Session key validation not working in pieforms

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.2 series:
  Fix Released
Status in Mahara 1.3 series:
  Fix Released

Bug description:
  The 'sesskey' hidden element is added automatically to every form
  created by the pieform constructor, but it's not validated because on
  submission, the sesskey's value is regenerated in the pieform
  constructor rather than read from the posted value.

  For the fix on stable versions, we should check the name of the hidden
  element and for 'sesskey', read it in from the appropriate parameter.

  On master, we should leave the hidden element as it is, and use a new
  pieform element type for sesskey validation.

  Reported by Bart van Delft.