mahara-contributors team mailing list archive

[Mahara Bot <dev@xxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/266
Committed: http://gitorious.org/mahara/mahara/commit/cdfbe963c2a0bb39faee472df1f8f82575ee5df7
Submitter: Francois Marier (francois@xxxxxxxxxxxxxxx)
Branch:    master

commit cdfbe963c2a0bb39faee472df1f8f82575ee5df7
Author: I��aki Arenaza <iarenaza@xxxxxxxxxxxxx>
Date:   Tue May 31 23:00:24 2011 +0200

    Update user info on login can prevent re-login if a LDAP attribute is empty.
    
    If the LDAP attribute is empty, some LDAP servers don't return the attribute in
    the answer (as an empty value). This means the missing attribute is not present
    in the $ldapdetails array returned by get_userinfo_ldap(). If we try to compare
    the missing entry with the existing user value, they are always different
    (unless the existing entry was also empty). Which means we assign an empty value
    to the user profile field (which is not allowed by the db).
    
    Simply testing if the LDAP attribute has been retrieved and is not empty before
    making the comparison fixes the problem.
    
    Tested with both MS AD (on W2003) and OpenLDAP 2.4.23 (on Debian).
    
    Fixes bug #656679 (which also fixes bug #788029)
    
    Change-Id: I81b59114b7fedeb8b575738b21ca4d6fd2670532
    Signed-off-by: I��aki Arenaza <iarenaza@xxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/656679

Title:
  Update user info on login can prevent re-login

Status in Mahara ePortfolio:
  Confirmed

Bug description:
  Using Active Directory LDAP for authentication. It seemed that having
  the 'Update user info on login' tickbox enabled caused Mahara to
  appear to go-offline to that user upon re-logins. I tried this with
  several users and it was repeatable. There was a similar sounding bug
  reported a while back I think - it may be the same.