mahara-contributors team mailing list archive

[François Marier <francois@xxxxxxxxxx>]

** Changed in: mahara
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/639636

Title:
  Hardcoded check for image block if a custom plugin specifies any
  blocktype, preventing installation + fix

Status in Mahara ePortfolio:
  Fix Released

Bug description:
  I'm coding a new artefact plugin and I've found that if I specify
  anything at all in the get_block_types() function of the main artefact
  class, installation fails because I haven't got class
  PluginBlocktypeImage available.

  This comes from a loop in artefact_check_plugin_sanity()
  (/artefact/lib.php around line 1150), which reads

  foreach ($types as $type) {
          $pluginclassname = generate_class_name('blocktype', 'image');

          // other stuff that's not relevant up to line 1168

          if (!class_exists($pluginclassname)) {
              throw new InstallationException(get_string('classmissing', 'error', $pluginclassname, $type, $pluginname));
          }
  }

  The plugin class name needs to generated dynamically:

  $pluginclassname = generate_class_name('blocktype', $type);

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/639636/+subscriptions