mahara-contributors team mailing list archive

[François Marier <francois@xxxxxxxxxx>]

** Changed in: mahara
    Milestone: None => 1.4.0

** Changed in: mahara
       Status: Fix Committed => Fix Released

** Changed in: mahara
     Assignee: (unassigned) => PiersHarding (piersharding)

** Changed in: mahara
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/688395

Title:
  /auth/saml doesn't redirect to deep-linked pages

Status in Mahara ePortfolio:
  Fix Released

Bug description:
  /auth/saml/index.php always redirects to $CFG->wwwroot, even when the
  original page requested is something else.

  The attached patch makes it so that it redirects to whatever page sent
  it to the /auth/saml/index.php in the first place.

  A couple of notes:

  1) I don't grok what's going on with the SESSION stuff...closing the
  session to let SAML do its thing, then opening the session again...so
  I just wrote directly to the $_SESSION array rather than using the
  abstraction.  You may want to refactor that part, unless what I did
  happens to make sense in the context.

  2)  I suppose there should be a config option to force redirecting to
  a front page and forbid deep-linking?  Not sure.

  Patch applies to both 1.3_STABLE and master.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/688395/+subscriptions