mahara-contributors team mailing list archive

[Mahara Bot <802338@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/394
Committed: http://gitorious.org/mahara/mahara/commit/230a9879c804eefe6de63e745d71ec6375a3b80a
Submitter: Francois Marier (francois@xxxxxxxxxxxxxxx)
Branch:    master

commit 230a9879c804eefe6de63e745d71ec6375a3b80a
Author: Brett Wilkins <brett@xxxxxxxxxxxxxxx>
Date:   Mon Jun 27 16:23:07 2011 +1200

    Reworking vimeo media source for externalvideo
    
    This is related to Bug #802338, removing the vague expression entirely.
    
    I have also taken the liberty of modifying this to always use iframes,
    as to better support devices without flash support.
    
    Change-Id: I180cf1b76a25d6a0d237a315025c2c1c732f8ca6
    Signed-off-by: Brett Wilkins <brett@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/802338

Title:
  vague regular expression in vimeo externalvideo media source

Status in Mahara ePortfolio:
  Confirmed

Bug description:
  A recent commit to Mahara master branch has a very vague regular expression:
  'match' => '#<embed src="http://(.+)" type="application/x-shockwave-flash" allowfullscreen="true" allowscriptaccess="always" width="([0-9]+)" height="([0-9]+)"></embed>#',

  This will accept any URL and call it a Vimeo URL.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/802338/+subscriptions