mahara-contributors team mailing list archive

[Mahara Bot <803267@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/405
Committed: http://gitorious.org/mahara/mahara/commit/fc107a53544c072b649fc8925e2fd8ab44d50ee3
Submitter: Ruslan Kabalin (ruslan.kabalin@xxxxxxxxxxx)
Branch:    master

commit fc107a53544c072b649fc8925e2fd8ab44d50ee3
Author: Brett Wilkins <brett@xxxxxxxxxxxxxxx>
Date:   Wed Jun 29 14:02:37 2011 +1200

    Fixing check for gnu-style braces
    
    Bug #803267
    GNU-syle braces should only apply to function definitions and conditional
    code blocks.
    
    Change-Id: Ib598abef440ac9923fe5bbe95fe5025df11d82f8
    Signed-off-by: Brett Wilkins <brett@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/803267

Title:
  Coding standards script doesn't cope with variable interpolation in
  heredocs

Status in Mahara ePortfolio:
  Confirmed

Bug description:
  Consider the following code snippet

  $js = <<< EOF
  addLoadEvent(function () {
      {$activities['pagination_js']}
  });
  EOF;

  The coding standards script trips up on the line inside
  addLoadEvent(), saying 'opening curly braces are do no need their own
  line.'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/803267/+subscriptions