mahara-contributors team mailing list archive

[Mahara Bot <803955@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/420
Committed: http://gitorious.org/mahara/mahara/commit/1744120c630d6196575ac98df7b135b321176ee5
Submitter: Hugh Davenport (hugh@xxxxxxxxxxxxxxx)
Branch:    master

commit 1744120c630d6196575ac98df7b135b321176ee5
Author: Andrew Robert Nicols <andrew.nicols@xxxxxxxxxxx>
Date:   Thu Jun 30 16:58:27 2011 +0100

    Fill $OVERRIDDEN with all variables set in config.php
    
    See bug #803955
    
    This does mean that $OVERRIDDEN will also get a list of database fields and
    plugins, but I think that more fields, is better than too few.
    
    Change-Id: I3fef6277484e48d5ec4c1609fbe1178f976333f6
    Signed-off-by: Andrew Robert Nicols <andrew.nicols@xxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/803955

Title:
  Overridden site admin fields not disabled unless also stored in
  database

Status in Mahara ePortfolio:
  In Progress

Bug description:
  If you explicitly set a field in config.php, then it /should/ be disabled in admin/site/options.php
  This currently only happens if that setting is also stored in the database.

  As a result, users believe that they can change the option, but when
  they then try to, the option is unset, the field greyed out, and there
  is no message informing them that they can't change the setting.

  This appears to stem from the way that the $OVERRIDDEN variable is
  filled in lib/mahara.php->load_config().

  At present, this grabs all config options set in the database.
  For any option in the database, it then checks for an override, and if it's already present in $CFG, it adds this to the OVERRIDDEN array. If it isn't present in $CFG already, it adds it to $CFG so that it's accessible.

  Have a patch to submit for this.

  Affects 1.4.x and master

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/803955/+subscriptions