mahara-contributors team mailing list archive

[Richard Mansfield <854369@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

When selecting files for a block, the filebrowser "owner" tabs (my
files, group files, etc.) are supposed to determine whether the upload
form is displayed.

However, when browsing group files, the tab upload rules are overridden
by code to show/hide the upload form depending on the group folder
permissions (introduced in commit
3ed6f3390c60de8f34dab3a4720272e6bd6cf21d).  So for example, when
configuring a block within a personal view, the upload form should
always be hidden when browsing group files, but it's not hidden when the
user has permission to edit the selected group folder.

The problem is that the filebrowser javascript doesn't remember whether
the currently selected tab allows uploads.

** Affects: mahara
     Importance: Low
     Assignee: Richard Mansfield (richard-mansfield)
         Status: In Progress

** Changed in: mahara
       Status: New => In Progress

** Changed in: mahara
   Importance: Undecided => Low

** Changed in: mahara
     Assignee: (unassigned) => Richard Mansfield (richard-mansfield)

** Changed in: mahara
    Milestone: None => 1.5.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/854369

Title:
  Upload form not hidden correctly when selecting group files in a block

Status in Mahara ePortfolio:
  In Progress

Bug description:
  When selecting files for a block, the filebrowser "owner" tabs (my
  files, group files, etc.) are supposed to determine whether the upload
  form is displayed.

  However, when browsing group files, the tab upload rules are
  overridden by code to show/hide the upload form depending on the group
  folder permissions (introduced in commit
  3ed6f3390c60de8f34dab3a4720272e6bd6cf21d).  So for example, when
  configuring a block within a personal view, the upload form should
  always be hidden when browsing group files, but it's not hidden when
  the user has permission to edit the selected group folder.

  The problem is that the filebrowser javascript doesn't remember
  whether the currently selected tab allows uploads.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/854369/+subscriptions