mahara-contributors team mailing list archive

[Mahara Bot <861985@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/752
Committed: http://gitorious.org/mahara/mahara/commit/c03258234b0db155d1eaea474f202c7872cb3eac
Submitter: Richard Mansfield (richardm@xxxxxxxxxx)
Branch:    master

commit c03258234b0db155d1eaea474f202c7872cb3eac
Author: Richard Mansfield <richard.mansfield@xxxxxxxxxxxxxxx>
Date:   Thu Sep 29 14:50:30 2011 +1300

    Fix acceptance of outdated friendship requests (bug #861985)
    
    If you submit an accept friendship form from the my friends or find
    friends page, but the request has disappeared in the time since you
    loaded the page, the user receives no feedback.  This patch ensures
    that the form is actually submitted and validated, and provides an
    appropriate message if the request has been denied or accepted.
    
    This patch also ensures that friend acceptance is saved when the
    submitted form appears on the second (or later) page of results.
    
    Change-Id: I0bdc8fb370670a8ddb1c41c7db2f3e37c9d70d11
    Signed-off-by: Richard Mansfield <richard.mansfield@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/861985

Title:
  Friendship acceptance from find friends is fragile

Status in Mahara ePortfolio:
  In Progress

Bug description:
  On the 2nd and later pages of find friends, accepting a friend request
  appears to submit without errors, but actually fails to add the user
  as a friend.

  Submitting a friendship acceptance form can also fail in a similar
  manner when friendship has been accepted or denied in another browser
  window since the page was loaded.

  If the database somehow ends up in a state where both a friend record
  and a friend request record exist for a pair of users, accepting
  friend requests fails with an sql error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/861985/+subscriptions