mahara-contributors team mailing list archive

[Mahara Bot <861985@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/753
Committed: http://gitorious.org/mahara/mahara/commit/6efd41bcdd9f4c73feb5f5c8de4a8feb666f3cfc
Submitter: Richard Mansfield (richardm@xxxxxxxxxx)
Branch:    master

commit 6efd41bcdd9f4c73feb5f5c8de4a8feb666f3cfc
Author: Richard Mansfield <richard.mansfield@xxxxxxxxxxxxxxx>
Date:   Thu Sep 29 16:09:10 2011 +1300

    Fixes for adding users with friendscontrol set to 'auto' (bug #861985)
    
    Adding users who automatically accept friends failed when the page
    from which the form was submitted was out of date.  This change fixes
    the case where a user adds a friend who has changed their friendscontrol
    setting since the page was loaded.  If they have turned friendscontrol
    back to 'auth', the submission will fail with an error; if they have in
    the meantime added a friend request to the user who's submitting the
    form, it will succeed, and if a user with an open friend request somehow
    submits the 'addfriend' form, the friend request will be removed.
    
    Change-Id: I3ab5c1cf4dd263126abb7d2a34490d18b69b4439
    Signed-off-by: Richard Mansfield <richard.mansfield@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/861985

Title:
  Friendship acceptance from find friends is fragile

Status in Mahara ePortfolio:
  In Progress

Bug description:
  On the 2nd and later pages of find friends, accepting a friend request
  appears to submit without errors, but actually fails to add the user
  as a friend.

  Submitting a friendship acceptance form can also fail in a similar
  manner when friendship has been accepted or denied in another browser
  window since the page was loaded.

  If the database somehow ends up in a state where both a friend record
  and a friend request record exist for a pair of users, accepting
  friend requests fails with an sql error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/861985/+subscriptions