mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #06454
[Bug 736665] A change has been merged
Reviewed: https://reviews.mahara.org/768
Committed: http://gitorious.org/mahara/mahara/commit/a65e40c4cdaed7922a01250682d11a98bd2b966b
Submitter: Richard Mansfield (richardm@xxxxxxxxxx)
Branch: master
commit a65e40c4cdaed7922a01250682d11a98bd2b966b
Author: Richard Mansfield <richard.mansfield@xxxxxxxxxxxxxxx>
Date: Tue Oct 4 15:29:50 2011 +1300
Stop users from editing note text in the wrong context (bug #736665)
When a user is allowed to put (for example) a group textbox inside
a personal view, they should not be able to edit the contents of
that textbox inside their personal view, because it's not clear
enough that they may be about to modify a note with a different
owner. This is especially dangerous when a group textbox has been
added to the individual views of different group members, and any
one member is able to modify the group textbox through their own
view.
When saving an html artefact from a textbox block configuration
form, this patch adds a check to ensure that the view owner is the
same as the artefact owner. If not, an error is not thrown, but
the artefact description is not updated either. A later commit
will ensure that users are made aware which html artefacts are
editable, and which are read-only before the configuration form is
submitted.
This change also allows users to include html artefacts in a
textbox even when they only have 'republish' permission on the
artefact.
Change-Id: I3ec49f59b04679853ecd57e300e72f23f6ff9c9d
Signed-off-by: Richard Mansfield <richard.mansfield@xxxxxxxxxxxxxxx>
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/736665
Title:
text box as artefact
Status in Mahara ePortfolio:
Fix Committed
Bug description:
result from the discussion at
http://mahara.org/interaction/forum/topic.php?id=3080 and previous
talk between Richard Mansfield and me
Currently, the text box is only available in one view and it is not
re-usable. It would be good to use it in multiple views like other
artefacts and to be able to comment on it.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/736665/+subscriptions
References