← Back to team overview

mahara-contributors team mailing list archive

[Bug 884962] [NEW] When the disablelogin config is true, the login sidebar still shows

 

Public bug reported:

Affects 1.4 and master

The guilty line is in htdocs/lib/web.php line 521 (master), 515 (1.4)
        if (!$USER->is_logged_in() && !(get_config('siteclosed') && get_config('disablelogin'))) {
it should be testing siteclosed OR disablelogin

Will push a patch for master, not sure if it is worthy for 1.4.1 (or
1.4.2 at this stage :D)

** Affects: mahara
     Importance: Low
     Assignee: Hugh Davenport (hugh-catalyst)
         Status: In Progress

** Changed in: mahara
       Status: New => In Progress

** Changed in: mahara
   Importance: Undecided => Low

** Changed in: mahara
     Assignee: (unassigned) => Hugh Davenport (hugh-catalyst)

** Changed in: mahara
    Milestone: None => 1.5.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/884962

Title:
  When the disablelogin config is true, the login sidebar still shows

Status in Mahara ePortfolio:
  In Progress

Bug description:
  Affects 1.4 and master

  The guilty line is in htdocs/lib/web.php line 521 (master), 515 (1.4)
          if (!$USER->is_logged_in() && !(get_config('siteclosed') && get_config('disablelogin'))) {
  it should be testing siteclosed OR disablelogin

  Will push a patch for master, not sure if it is worthy for 1.4.1 (or
  1.4.2 at this stage :D)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/884962/+subscriptions


Follow ups

References