mahara-contributors team mailing list archive

[Mahara Bot <887002@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/834
Committed: http://gitorious.org/mahara/mahara/commit/79cf0eb22fae7a6e9abbde041bac15e525933cfe
Submitter: Richard Mansfield (richardm@xxxxxxxxxx)
Branch:    master

commit 79cf0eb22fae7a6e9abbde041bac15e525933cfe
Author: Richard Mansfield <richard.mansfield@xxxxxxxxxxxxxxx>
Date:   Mon Nov 7 18:26:44 2011 +1300

    Check value of static variable in group_current_group (bug #887002)
    
    The $dying variable mentioned in the comment being deleted in this
    patch is not necessary because checking the value of $group stops
    a 2nd exception being thrown.
    
    The return value of group_current_group is only checked in the smarty
    function to stop a "Trying to get property of non-object" warning
    from being logged.
    
    Change-Id: Ic78458bbe6ebe52fc4cb82cc661949d97ed450b4
    Signed-off-by: Richard Mansfield <richard.mansfield@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/887002

Title:
  Group data queried too many times on group pages

Status in Mahara ePortfolio:
  In Progress

Bug description:
  The group_current_group() function fails to use its static variable,
  and queries the db every time it's called, resulting in several
  pointless queries on some group pages.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/887002/+subscriptions