mahara-contributors team mailing list archive

[Mahara Bot <887400@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/835
Committed: http://gitorious.org/mahara/mahara/commit/b2e348702b5c9d77be08282260342b49376465ba
Submitter: Francois Marier (francois@xxxxxxxxxxxxxxx)
Branch:    master

commit b2e348702b5c9d77be08282260342b49376465ba
Author: Richard Mansfield <richard.mansfield@xxxxxxxxxxxxxxx>
Date:   Tue Nov 8 14:39:18 2011 +1300

    Read entire _config table on call to get_config_plugin (bug #887400)
    
    get_config_plugin only pulls in records from the given plugin, but it
    might as well read the entire (tiny) table, so that for example the
    following two calls result in one query rather than two:
     get_plugin_config('artefact', 'internal', 'profilemandatory')
     get_plugin_config('artefact', 'file', 'defaultquota')
    
    Change-Id: I28d74179330178a40d4787bdb9e8e4ed1e0a0e60
    Signed-off-by: Richard Mansfield <richard.mansfield@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/887400

Title:
  get_config_plugin does too many queries

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  The get_config_plugin function fails to remember when a query for a
  particular value returns nothing, and queries the table again on every
  subsequent call.  Also, it can be improved by reading entire
  <plugintype>_config tables (they're very small) instead of just
  reading values for one plugin at a time.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/887400/+subscriptions