mahara-contributors team mailing list archive

[Mahara Bot <849716@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/879
Committed: http://gitorious.org/mahara/mahara/commit/4384e74773f660cd24da9e9f2d4deb897eb88e73
Submitter: Richard Mansfield (richardm@xxxxxxxxxx)
Branch:    master

commit 4384e74773f660cd24da9e9f2d4deb897eb88e73
Author: Richard Mansfield <richard.mansfield@xxxxxxxxxxxxxxx>
Date:   Wed Nov 23 18:22:21 2011 +1300

    Remove wwwroot from notification urls (bug #849716)
    
    Urls stored in the url field of notification_internal_activity contain
    the site's wwwroot.  This leads to broken links when the wwwroot is
    changed.  It also dangerously turns what should be local links into
    remote ones when for example a production database is copied into a
    test Mahara instance.
    
    This patch does three things:
    - Removes the wwwroot from urls passed to ActivityType constructors
    - Adds the wwwroot back on the url when sending email and emaildigest
      notifications, and when displaying them on the site.
    - Removes the wwwroot from the url in all existing rows of
      notification_internal_activity.
    
    Change-Id: I00ae1abc65be79030ed4c572ce951edc43f7a034
    Signed-off-by: Richard Mansfield <richard.mansfield@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/849716

Title:
  Notification url field contains wwwroot

Status in Mahara ePortfolio:
  Confirmed

Bug description:
  The notification_internal_activity table has a url field which is used
  to provide the user with a link to whatever thing the notification is
  about.  This url includes the site's wwwroot.  That's useful when it's
  sent out in an email, but it's not cool for the internally stored
  notifications, because if the site's wwwroot changes, all those old
  links will break.  We should just store the local url without the
  wwwroot.

  It's probably a good idea to upgrade & remove all wwwroots from old
  notifications - carefully, because it's a big table.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/849716/+subscriptions