← Back to team overview

mahara-contributors team mailing list archive

[Bug 894592] A change has been merged

 

Reviewed:  https://reviews.mahara.org/885
Committed: http://gitorious.org/mahara/mahara/commit/f402e2510f6c74ff8f81974d2150616fca812984
Submitter: Richard Mansfield (richardm@xxxxxxxxxx)
Branch:    master

commit f402e2510f6c74ff8f81974d2150616fca812984
Author: Richard Mansfield <richard.mansfield@xxxxxxxxxxxxxxx>
Date:   Fri Nov 25 12:24:13 2011 +1300

    Fix warnings when rendering access type after error (bug #894592)
    
    When the view access page is submitted with an error, php warnings
    are emitted when the rendering the access rows.
    
    First because the pieform element assumes that an 'accesstype' index
    exists in the accesslist value, but this is only true when the
    accesslist still contains database records rather than the list
    submitted by the form.
    
    Second,  disabled public access record causes a warning because
    'public' isn't in the list of 'presets' allowed to be added to the
    view, so we need to keep track of the allowed presets and the full
    list of presets that may have been allowed in the past.
    
    Change-Id: Ic4db20738d53a52caeb3ebef0b44660dcb7c9ee6
    Signed-off-by: Richard Mansfield <richard.mansfield@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/894592

Title:
  Multiple bugs with date errors on view access page

Status in Mahara ePortfolio:
  In Progress

Bug description:
  There are several bugs that occur when submitting the view access form with errors in the dates:
  - the list of access types is not always redisplayed correctly
  - warnings sometimes appear in the logs for bad array indexes
  - some undefined strings in the error messages

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/894592/+subscriptions


References