mahara-contributors team mailing list archive

[Mahara Bot <837013@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/860
Committed: http://gitorious.org/mahara/mahara/commit/58ddf16fb130793bfaa159e5374f095ce1916981
Submitter: Francois Marier (francois@xxxxxxxxxxxxxxx)
Branch:    master

commit 58ddf16fb130793bfaa159e5374f095ce1916981
Author: Hugh Davenport <hugh@xxxxxxxxxxxxxxx>
Date:   Tue Nov 15 16:45:03 2011 +1300

    Remove incorrect parameter to execute_sql
    
    Bug #837013
    
    Change-Id: I54e1964487c885bbde709bef51e4e377b1ae8904
    Signed-off-by: Hugh Davenport <hugh@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/837013

Title:
  Incorrect parameter passing between execute_sql_arr and execute_sql

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  I'm looking at the very latest 1.3.7 code - not had a chance to look
  in 1.4.

  Looking at the function execute_sql_arr(.....) in dml.php (line 1398
  in mine) it has a parameter called $feedback which is described as
  'specify to show status info (true) or not (false)'.

  The function does some stuff and then makes a call to execute_sql(
  $sql, $feedback ) noting $feedback as the second parameter (boolean).
  However, if you look at execute_sql() (line 135 for me), the second
  parameter is called $values and is an array.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/837013/+subscriptions