mahara-contributors team mailing list archive

[Mahara Bot <916998@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/993
Committed: http://gitorious.org/mahara/mahara/commit/9bc9d15c2780e7b12f49595a482d65ed8cd76e53
Submitter: Francois Marier (francois@xxxxxxxxxxxxxxx)
Branch:    master

commit 9bc9d15c2780e7b12f49595a482d65ed8cd76e53
Author: Richard Mansfield <richard.mansfield@xxxxxxxxxxxxxxx>
Date:   Mon Jan 16 14:12:07 2012 +1300

    Fix sql error in bulk user deletion (bug #916998)
    
    When a user is deleted, deletion of notification_internal_activity
    records can fail with a foreign key error when another row in
    notification_internal_activity has a parent field pointing to one of
    the records we are trying to delete.  This is fixed by setting the
    parent fields to null before deletion.
    
    The handle_event('deleteuser') call in delete_user is also moved
    inside the transaction, to ensure that deleted users will have their
    notifications deleted correctly.  Other subscribers to the deleteuser
    event in core should be unaffected.
    
    Change-Id: Ibc0a695e986bb175a00441f02d3e40abf38cbcde
    Signed-off-by: Richard Mansfield <richard.mansfield@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/916998

Title:
  Bulk deletion fails for users with personal messages with replies

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  When a user is deleted, an attempt is made to delete all
  notification_internal_activity records for that user.  This attempt
  can fail, because in the case of personal message threads, other rows
  in notification_internal_activity can point to the records we are
  trying to delete, resulting in a foreign key error.

  This error occurs outside the db transaction in delete_user(), so
  usually this bug doesn't stop users from being deleted, it stops their
  internal notifications from being deleted.  In bulk delete operations,
  all the calls to delete_user are wrapped in a transaction, so deletion
  fails.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/916998/+subscriptions