← Back to team overview

mahara-contributors team mailing list archive

[Bug 933937] Re: Conflicting method names in auth plugin and instance configuration

 

** Changed in: mahara
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/933937

Title:
  Conflicting method names in auth plugin and instance configuration

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  The methods called for validation and submission during auth plugin
  configuration and auth instance configuration have the same names, but
  these methods deal with completely different fields, and are passed
  arguments in a different order.

  In core, this is only a problem for the saml plugin (the only auth
  plugin to have global configuration), but we should give these methods
  different names so that the saml plugin doesn't have to swap arguments
  around, and to avoid confusion for other plugin developers.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/933937/+subscriptions


References