mahara-contributors team mailing list archive

[Mahara Bot <968697@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/1104
Committed: http://gitorious.org/mahara/mahara/commit/938fa7db02de52d8722ea165be9153e8b09f8b4f
Submitter: Francois Marier (francois@xxxxxxxxxxxxxxx)
Branch:    master

commit 938fa7db02de52d8722ea165be9153e8b09f8b4f
Author: Richard Mansfield <richard.mansfield@xxxxxxxxxxxxxxx>
Date:   Wed Mar 21 14:26:25 2012 +1300

    Fix get_string calls for duplicate remote username message (bug #968697)
    
    When uploading users from a csv file, the remote usernames given in
    the file are checked for duplicates.  When a duplicate is found,
    get_string is called to generate the error message using the string
    key 'uploadcsverrorremoteusertaken', but in two of three instances, it
    is called with too few arguments to sprintf.  Sometimes this results
    in no error being reported to the user at all.
    
    The error is fixed here by creating a new string without the second
    argument for the first call, and by passing the additional argument in
    the second call.
    
    Change-Id: Iff93385dee206394c74b1d6b1ad9484e90026dd4
    Signed-off-by: Richard Mansfield <richard.mansfield@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/968697

Title:
  Bad calls to get_string upload csv for duplicate remote usernames

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  When uploading users from a csv file, the remote usernames given in
  the file are checked for duplicates.  When a duplicate is found,
  get_string is called to generate the error message using the string
  key 'uploadcsverrorremoteusertaken', but in two of three instances, it
  is called with too few arguments to sprintf. Sometimes this results in
  no error being reported to the user at all.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/968697/+subscriptions