mahara-contributors team mailing list archive

[Mahara Bot <1052062@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/1723
Committed: http://gitorious.org/mahara/mahara/commit/60e78d1904a2206f5a4923e5e3829dbd8321ca2e
Submitter: Hugh Davenport (hugh@xxxxxxxxxxxxxxx)
Branch:    1.6_STABLE

commit 60e78d1904a2206f5a4923e5e3829dbd8321ca2e
Author: Son Nguyen <son.nguyen@xxxxxxxxxxxxxxx>
Date:   Tue Sep 18 14:26:45 2012 +1200

    Fix: the <link> tag in HTML should have no end tag (bug #1052062)
    
    Change-Id: I58aa9833025de37e1970c16b67f4c3bc14cf17d4
    Signed-off-by: Son Nguyen <son.nguyen@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/1052062

Title:
  Invalid short tag on site logo link in header

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  Mahara 1.6 generates this code out of
  `htdocs/theme/raw/templates/header/head.tpl` and/or
  `htdocs/theme/default/templates/header/head.tpl`:

      <link rel="image_src" href="{$sitelogo}" />

  Since the DOCTYPE specified HTML 4.01, this is technically invalid.
  It should either not use the short tag or (my preference) change the
  doctype to HTML5 (or do both).

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1052062/+subscriptions