← Back to team overview

mahara-contributors team mailing list archive

[Bug 1057846] A change has been merged

 

Reviewed:  https://reviews.mahara.org/1742
Committed: http://gitorious.org/mahara/mahara/commit/a9bd7f9be8ed20a696bf8b7352c7078f98cde826
Submitter: Melissa Draper (melissa@xxxxxxxxxxxxxxx)
Branch:    master

commit a9bd7f9be8ed20a696bf8b7352c7078f98cde826
Author: Son Nguyen <son.nguyen@xxxxxxxxxxxxxxx>
Date:   Wed Oct 3 17:45:07 2012 +1300

    Replace the call removeElement() in filebrowser.js (bug #1057846)
    
    This call causes the callback() not to call after upload.
    
    1. When click 'Remove', keep the file in the selected list, only hide
    it, remove the hidden input element
    2. When click 'Select' or Upload a new file, add new row or update the
    selected list.
    3. When update file title and description, update the list
    4. When change 'Image selection', recalculate the width of the
    configuration box
    5. After update file title and description and upload a file,
    recalculate the width of the configuration box
    
    Change-Id: I57b97c13086df3b5c828c9b731ebae9a00cd2d69
    Signed-off-by: Son Nguyen <son.nguyen@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/1057846

Title:
  removing image in block before adding new one causes upload failure

Status in Mahara ePortfolio:
  In Progress

Bug description:
  Version: master
  Browser: Firefox 14.0.1
  OS: Ubuntu

  To reproduce:
  * Add gallery block to page
  * Choose the individual images radio
  * Upload an image or select an image from the list shown
  * Change your mind and remove the image
  * Upload another image -- the uploading hangs and the image is called "undefined".

  This is a regression. It worked fine on 1.5_STABLE.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1057846/+subscriptions


References