mahara-contributors team mailing list archive

[Mahara Bot <1095834@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/1943
Committed: http://gitorious.org/mahara/mahara/commit/054f4f8aea52d651e8dd3fc4fafb10993b555e77
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    master

commit 054f4f8aea52d651e8dd3fc4fafb10993b555e77
Author: Son Nguyen <son.nguyen@xxxxxxxxxxxxxxx>
Date:   Fri Jan 4 12:27:04 2013 +1300

    Fix the problem of searching for the string: '0' (Bug #1095834)
    
    Wrong use of the empty() function causes this problem.
     - !empty($query) must be replaced by isset($query) && ($query != '')
     - !empty($values['query']) replaced by isset($values['query']) &&
    ($values['query'] != '')
    
    Change-Id: I5dee9187f48fa3b3f1eeddd23bf29413bb6433c8
    Signed-off-by: Son Nguyen <son.nguyen@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/1095834

Title:
  Wrong result when searching for the special string: '0'

Status in Mahara ePortfolio:
  In Progress

Bug description:
  Version: All
  Platform: All
  Browser: All

  In some pages that use the function views_by_owner(), the search query
  will reset to be empty when enter the string "0" in the text box for
  searching.

  The following pages need to be tested:
   - the page "My pages" Porfolio/Pages (/view/index.php), 
   - the page "Institution pages" Administration/Institutions/Pages (/view/institutionviews.php)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1095834/+subscriptions