mahara-contributors team mailing list archive
-
mahara-contributors team
-
Mailing list archive
-
Message #12045
[Bug 1150831] Re: Trailing slash missing in directory URL
Hi Tony,
I've submitted a patch for this issue to https://reviews.mahara.org/2087
. Please give it a test, if you can.
Cheers,
Aaron
** Also affects: mahara/1.5
Importance: Undecided
Status: New
** Also affects: mahara/1.6
Importance: Undecided
Status: New
** Also affects: mahara/1.7
Importance: Undecided
Status: New
** Also affects: mahara/1.8
Importance: Undecided
Status: New
** Also affects: mahara/trunk
Importance: Low
Status: In Progress
** Changed in: mahara/1.5
Importance: Undecided => Low
** Changed in: mahara/1.6
Importance: Undecided => Low
** Changed in: mahara/1.7
Importance: Undecided => Low
** Changed in: mahara/1.8
Importance: Undecided => Low
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contrib members
https://bugs.launchpad.net/bugs/1150831
Title:
Trailing slash missing in directory URL
Status in Mahara ePortfolio:
In Progress
Status in Mahara 1.5 series:
New
Status in Mahara 1.6 series:
New
Status in Mahara 1.7 series:
New
Status in Mahara 1.8 series:
New
Status in Mahara trunk series:
In Progress
Bug description:
In https://mahara.org/interaction/forum/topic.php?id=5269 , a user
reported that clicking the "Done" button after editing a portfolio
page, caused the user to be sent to a non-https version of their site,
interrupting their login session.
After a bit of troubleshooting, it turned out that the problem was
caused in part, by the fact that in raw/templates/view/blocks.tpl, the
form containing the "Done" button submits to the url
"{$WWWROOT}/view", rather than "{$WWWROOT}/view/". (note the missing
trailing slash)
With most web servers, if you try to access a directory, but leave the
trailing slash off the end, you will be redirected to the same URL
with a trailing slash. (See
http://httpd.apache.org/docs/2.2/mod/mod_dir.html#directoryslash for
documentation of this in Apache, for instance). Somehow, this was
causing problems for this user.
Since this can cause problems for some users, and since the correct
URL for a directory has a trailing slash on the end anyway, we should
fix this so that our directory URLs have a trailing slash. At the
least, it'll save on a little bit of web traffic, by avoiding a
redirect.
This problem was noticed in /view/blocks.tpl, but it's possible it
could occur in other templates as well.
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1150831/+subscriptions
References