← Back to team overview

mahara-contributors team mailing list archive

[Bug 1174540] Re: Lincense issue on vanilla 1.7

 

I was unable to replicate, but I did notice a warning generated on line
930 htdocs/blocktype/lib.php as Gregor described, which is caused
because the placeholder elements returned by license_form_el_advanced()
and license_form_el_basic() don't have a 'type' key. For me, the
theories would show up on the next page load. My theory is that for some
reason in Gregor's install these warnings were popping up in his JSON
responses, fouling them up so that the config form hung.

Here's a patch to squelch those warnings:
https://reviews.mahara.org/2099

** Also affects: mahara/1.7
   Importance: Undecided
       Status: New

** Changed in: mahara
    Milestone: None => 1.8.0rc1

** Changed in: mahara/1.7
    Milestone: None => 1.7.1

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contrib members
https://bugs.launchpad.net/bugs/1174540

Title:
  Lincense issue on vanilla 1.7

Status in Mahara ePortfolio:
  New
Status in Mahara 1.7 series:
  New

Bug description:
  from Gregor at https://mahara.org/interaction/forum/topic.php?id=5394

  Installed fresh instance of Mahara 1.7.0. I have only one user - admin
  user. No data is set, everything is default as install process created
  it.

  Created new page and tried to add Textbox block. The rendering of
  config form took forever... Upon investigation I found out that it is
  caused because 'license' and 'license_advanced' pieform elements are
  created without 'type' which would indicate the type of Pieform. This
  is needed in line 930 of 'build_configure_form' function in file
  htdocs/blocktype/lib.php which tries to reference Pieform javascript
  function:

  line 930: $function = 'pieform_element_' . $element['type'] .
  '_views_js';

  I suspect it can't be done since 'type' index isn't set...

  Haven't added it to bugtracker since I want you guys to please confirm
  this.

  Kind regards,
  Gregor

  -------------------

  When I turn on the license, the problem vanishes...

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1174540/+subscriptions


References