mahara-contributors team mailing list archive

[Mahara Bot <1174540@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/2133
Committed: http://gitorious.org/mahara/mahara/commit/c084c41b0dcfe4a8116fe8f73ce9123a8655124e
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    1.7_STABLE

commit c084c41b0dcfe4a8116fe8f73ce9123a8655124e
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Tue Apr 30 17:16:04 2013 +1200

Fix warnings that happen when licenses are disabled

Bug#1174540. Some warnings were because the placeholder empty elements
returned the license_form_el_* functions were missing their "type". Others
were because code for some content was trying to process the license elements
even if licenses were disabled and thus the elements were missing.

Signed-off-by: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Change-Id: I961fec3aa4fefb737b497638c59a0426db95d04b

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contrib members
https://bugs.launchpad.net/bugs/1174540

Title:
  License issue on vanilla 1.7

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.7 series:
  Fix Committed

Bug description:
  from Gregor at https://mahara.org/interaction/forum/topic.php?id=5394

  Installed fresh instance of Mahara 1.7.0. I have only one user - admin
  user. No data is set, everything is default as install process created
  it.

  Created new page and tried to add Textbox block. The rendering of
  config form took forever... Upon investigation I found out that it is
  caused because 'license' and 'license_advanced' pieform elements are
  created without 'type' which would indicate the type of Pieform. This
  is needed in line 930 of 'build_configure_form' function in file
  htdocs/blocktype/lib.php which tries to reference Pieform javascript
  function:

  line 930: $function = 'pieform_element_' . $element['type'] .
  '_views_js';

  I suspect it can't be done since 'type' index isn't set...

  Haven't added it to bugtracker since I want you guys to please confirm
  this.

  Kind regards,
  Gregor

  -------------------

  When I turn on the license, the problem vanishes...

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1174540/+subscriptions