← Back to team overview

mahara-contributors team mailing list archive

[Bug 1185297] A change has been merged

 

Reviewed:  https://reviews.mahara.org/2251
Committed: http://gitorious.org/mahara/mahara/commit/46aba6b4dc2e2a2576826be6cc5bab28fed7a355
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit 46aba6b4dc2e2a2576826be6cc5bab28fed7a355
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Thu May 30 11:03:16 2013 +1200

Removing $cfg->themeprefs because it has been replaced by
$cfg->sitethemeprefs

Bug #1185297: The $cfg->themeprefs setting was removed in bug #793308

Change-Id: Ifcea19569d62eeb03cb26e098d74ab4d535f61e3
Signed-off-by: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contrib members
https://bugs.launchpad.net/bugs/1185297

Title:
  Document more $cfg options

Status in Mahara ePortfolio:
  Triaged

Bug description:
  I think it would be a great idea if we went through the code, found as
  many of the config options as we can (by searching for $CFG and
  get_config()), and made sure they were properly documented in one of
  three ways:

  1. If it's a setting that should be hard-coded and most users will
  want/need to set it, put it in config-dist.php

  2. If it's a setting that should be hard-coded but is experimental,
  advanced, or less likely to be used, put it in lib/config-defaults.php

  3. Or give it a UI front-end setting on the Admin pages. But keep in
  mind possible security implications -- anything settable by the UI can
  be abused by XSS, so for instance filesystem paths should not be set
  in the UI because that makes a handy escalation from XSS to
  filesystem.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1185297/+subscriptions


References