mahara-contributors team mailing list archive

[Aaron Wells <1188001@xxxxxxxxxxxxxxxxxx>]

The bigger problem is that our smarty/dwoo and pieform frameworks both
operate pretty much entirely through side-effects. When people call
smarty() or pieform(), they don't realize that calling that constructor
is going to start rendering the page, sending headers and such!

Anyway, the simple fix for these warnings is to shift things around so
that all forms are created before the smarty is created.

Here's a gerrit fix for this one: https://reviews.mahara.org/2265

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contrib members
https://bugs.launchpad.net/bugs/1188001

Title:
  Page view throws headdata warning, if group submissions enabled

Status in Mahara ePortfolio:
  In Progress

Bug description:
  1. Create a Page
  2. Create a Group and enable "Allow submissions" and join the group
  3. View the Page.

  You'll see a menu asking if you want to submit the page to the group.
  You'll also see this warning message:

  [Thu Jun 06 17:23:15 2013] [error] [client 127.0.0.1] [WAR] c3 (lib/pieforms/pieform.php:1408) Pieform element view_group_submission_form_8_options wants to add headdata to the page, but it's too late. Build your form before generating the page.
  [Thu Jun 06 17:23:15 2013] [error] [client 127.0.0.1] Call stack (most recent first):
  [Thu Jun 06 17:23:15 2013] [error] [client 127.0.0.1]   * log_message("Pieform element view_group_submission_form_8_optio...", 8, true, true) at /home/aaronw/www/mahara/htdocs/lib/errors.php:109
  [Thu Jun 06 17:23:15 2013] [error] [client 127.0.0.1]   * log_warn("Pieform element view_group_submission_form_8_optio...") at /home/aaronw/www/mahara/htdocs/lib/pieforms/pieform.php:1408
  [Thu Jun 06 17:23:15 2013] [error] [client 127.0.0.1]   * Pieform->build_element_html(array(size 10)) at /home/aaronw/www/mahara/htdocs/lib/pieforms/pieform.php:659
  [Thu Jun 06 17:23:15 2013] [error] [client 127.0.0.1]   * Pieform->build() at /home/aaronw/www/mahara/htdocs/lib/pieforms/pieform.php:162
  [Thu Jun 06 17:23:15 2013] [error] [client 127.0.0.1]   * Pieform::process(array(size 6)) at /home/aaronw/www/mahara/htdocs/lib/pieforms/pieform.php:71
  [Thu Jun 06 17:23:15 2013] [error] [client 127.0.0.1]   * pieform(array(size 6)) at /home/aaronw/www/mahara/htdocs/lib/view.php:4535
  [Thu Jun 06 17:23:15 2013] [error] [client 127.0.0.1]   * view_group_submission_form(object(View), array(size 1), "view") at /home/aaronw/www/mahara/htdocs/view/view.php:339

  It's the same old story, of instantiating a pieform() object after
  instantiating a smarty() object.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1188001/+subscriptions