mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

i found a bug relating to the commit done for this bug:

I'm got this error:
[WAR] fd (lib/errors.php:749) Failed to get a recordset: mysql error: [1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'FALSE' at line 1] in EXECUTE("SELECT COUNT(*) FROM "usr" u WHERE u.id <> 0 AND u.deleted = 0AND FALSE")
Command was: SELECT COUNT(*) FROM "usr" u WHERE u.id <> 0 AND u.deleted = 0AND FALSE

Looks like the line 463 in search/internal/lib.php needs to be

 $where .= ' AND FALSE';

not

$where .= 'AND FALSE';

So I submitted a patch https://reviews.mahara.org/#/c/2281/ to fix it

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contrib members
https://bugs.launchpad.net/bugs/1166499

Title:
  Filter out accounts with duplicate email address

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  Version: master
  Platform: all
  Browsers: all

  In order to find users (accounts) whose email address is shared by
  another user, in 'User search' page, we need to implement a filter
  check box.

  If the searcher has ticked the checkbox, they will see all email addresses for
  the users in the search results

  The non-unique email address(es) should be marked in the search
  results

  Institution administrators will see users from their institution who have an email
  address which is shared by a user outside their institution. However, they will not be
  able to see the matching user from outside their institution.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1166499/+subscriptions