mahara-contributors team mailing list archive

[Mahara Bot <1150831@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/2308
Committed: http://gitorious.org/mahara/mahara/commit/168db2f1eb9c1cf050b1a82e4d1b2f0dba55abb8
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    1.5_STABLE

commit 168db2f1eb9c1cf050b1a82e4d1b2f0dba55abb8
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Fri Apr 26 11:44:43 2013 +1200

Making links to directory index.php files more explicit

Bug #1150831: Some links to directory index.php files left off the
trailing slash,
i.e. "{$WWWROOT}/view". This caused unnecessary redirects and greater
potential for
errors in users' web server setups. While I was at it, for all links to
directories
other than $WWWROOT itself, I changed them to be explicitly links to
"index.php".

Also fixed the Windows-style line endings in homeinfo.tpl

Fix all implicit links

Change-Id: Ic77094a4a48dc13ba63c37ad43b53767187e505d

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contrib members
https://bugs.launchpad.net/bugs/1150831

Title:
  Trailing slash missing in directory URL

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.5 series:
  Fix Committed
Status in Mahara 1.6 series:
  Fix Committed
Status in Mahara 1.7 series:
  Fix Committed

Bug description:
  In https://mahara.org/interaction/forum/topic.php?id=5269 , a user
  reported that clicking the "Done" button after editing a portfolio
  page, caused the user to be sent to a non-https version of their site,
  interrupting their login session.

  After a bit of troubleshooting, it turned out that the problem was
  caused in part, by the fact that in raw/templates/view/blocks.tpl, the
  form containing the "Done" button submits to the url
  "{$WWWROOT}/view", rather than "{$WWWROOT}/view/". (note the missing
  trailing slash)

  With most web servers, if you try to access a directory, but leave the
  trailing slash off the end, you will be redirected to the same URL
  with a trailing slash. (See
  http://httpd.apache.org/docs/2.2/mod/mod_dir.html#directoryslash for
  documentation of this in Apache, for instance). Somehow, this was
  causing problems for this user.

  Since this can cause problems for some users, and since the correct
  URL for a directory has a trailing slash on the end anyway, we should
  fix this so that our directory URLs have a trailing slash. At the
  least, it'll save on a little bit of web traffic, by avoiding a
  redirect.

  This problem was noticed in /view/blocks.tpl, but it's possible it
  could occur in other templates as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1150831/+subscriptions