mahara-contributors team mailing list archive

[Mahara Bot <1207140@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/2385
Committed: http://gitorious.org/mahara/mahara/commit/dac25c9b90c1de8815db6acbe18242fe2789b406
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    1.7_STABLE

commit dac25c9b90c1de8815db6acbe18242fe2789b406
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Fri Aug 2 10:11:23 2013 +1200

Add protocol to Youtube iframe code (Bug #1207140)

The youtube iframe code lacks the http: or https: protocol
- so we add it in based on mahara site protocol

Change-Id: Id1c8e026c9bad3baa07643dea5bd30477412902e
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contrib members
https://bugs.launchpad.net/bugs/1207140

Title:
  YouTube filter requires updates

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.6 series:
  In Progress
Status in Mahara 1.7 series:
  Fix Committed
Status in Mahara 1.8 series:
  In Progress

Bug description:
  1. The iframe embed code for YouTube videos does not have the protocol
  included anymore thus causing problems when trying to embed the code
  into a site.

  The code reads:
  <iframe width="560" height="315" src="//www.youtube.com/embed/XXXXX?rel=0" frameborder="0" allowfullscreen></iframe>

  YouTube says:

  ''Just using //: instead of http:// or https:// means that you would
  like to use whichever protocol the parent page is using.

  So a page called http://example.com with include http://youtube.com
  and a page called https://example.com with include https://youtube.com

  It's intentional.''

  https://groups.google.com/a/googleproductforums.com/d/msgid/youtube
  /bce484af-b2e6-4f6e-9bc0-6c7617e08406%40googleproductforums.com

  2. When someone wants to use the YouTube URL from a mobile device, it
  is shortened to youtu.be. However, these videos can't be embedded
  because the filter doesn't understand that URL.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1207140/+subscriptions