mahara-contributors team mailing list archive

[Mahara Bot <1207140@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/2403
Committed: http://gitorious.org/mahara/mahara/commit/1bc5bd1a0a064fc0e99d2b87d02852f23ce1c461
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    master

commit 1bc5bd1a0a064fc0e99d2b87d02852f23ce1c461
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Tue Aug 13 18:44:16 2013 +1200

Revert "Add protocol to Youtube iframe code (Bug #1207140)"

This reverts commit 66674d0c2190354b9d24a5632af60650b05ceea8.

This patch adds an additional "http://"; to the beginning of each URL
each time you save an existing external content block! "http://"; becomes
"http://http://";

Change-Id: I37f21d30abad8c0b80bf2793614793f087d346fc

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contrib members
https://bugs.launchpad.net/bugs/1207140

Title:
  YouTube filter requires updates

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.6 series:
  In Progress
Status in Mahara 1.7 series:
  Fix Committed
Status in Mahara 1.8 series:
  In Progress

Bug description:
  1. The iframe embed code for YouTube videos does not have the protocol
  included anymore thus causing problems when trying to embed the code
  into a site.

  The code reads:
  <iframe width="560" height="315" src="//www.youtube.com/embed/XXXXX?rel=0" frameborder="0" allowfullscreen></iframe>

  YouTube says:

  ''Just using //: instead of http:// or https:// means that you would
  like to use whichever protocol the parent page is using.

  So a page called http://example.com with include http://youtube.com
  and a page called https://example.com with include https://youtube.com

  It's intentional.''

  https://groups.google.com/a/googleproductforums.com/d/msgid/youtube
  /bce484af-b2e6-4f6e-9bc0-6c7617e08406%40googleproductforums.com

  2. When someone wants to use the YouTube URL from a mobile device, it
  is shortened to youtu.be. However, these videos can't be embedded
  because the filter doesn't understand that URL.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1207140/+subscriptions