mahara-contributors team mailing list archive

[Mahara Bot <1207140@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/2428
Committed: http://gitorious.org/mahara/mahara/commit/443f1078debf756379e94d395e3d0021b69827cc
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    1.7_STABLE

commit 443f1078debf756379e94d395e3d0021b69827cc
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Thu Aug 22 15:45:19 2013 +1200

Correct Mahara 1.7 version number

The patch for Bug #1207140 erroneously raised the Mahara 1.7 version number too high.
Mahara versioning policy says that version numbers within a stable branch should only
increment by 1.

Change-Id: Iedcca7281494f4826df60621fe48df0cba4f36e1

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contrib members
https://bugs.launchpad.net/bugs/1207140

Title:
  YouTube iframe filter doesn't support the //youtube.com URLs YouTube
  now provides in embed code

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.6 series:
  Fix Committed
Status in Mahara 1.7 series:
  Fix Committed
Status in Mahara 1.8 series:
  Fix Committed

Bug description:
  In response to FireFox's change in not supporting iframes with a
  http/https protocol that doesn't match the protocol of the parent
  page, YouTube's embed code now lists protocol-relative URLs. These
  start with "//www.youtube.com", no "http://";. This is a standard type
  of relative URL/URI, but our code doesn't support it.

  Since we already store the allowed iframe domains without a protocol
  in front of them, we should also support these protocol-relative URLs.

  To replicate:
  1. Open up a YouTube video on youtube.com
  2. Click "Share" and then "Embed"
  3. Make sure you have NOT ticked the "Use old embed code" box
  4. You should get an iframe embed code, like this: <iframe width="420" height="315" src="//www.youtube.com/embed/NkyEOrQiGMQ" frameborder="0" allowfullscreen></iframe>
  5. Paste this into an external media block or a text block in Mahara

  Expected result: You should be able to view the video once you've saved the block
  Actual result: The block will not display the video

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1207140/+subscriptions