mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

The problem where some images are not showing up is because they tend to
be protocol relative urls to the images and the Mahara system tries to
append a url to them but this makes the path incorrect.

eg for slideshare (http://www.slideshare.net/rss/latest)

There are image links in the feed like:

//cdn.slidesharecdn.com/ss_thumbnails/lptrnhc2008cbnnhtnghththutit360-130902225125-phpapp02-thumbnail-2.jpg

and mahara sees this as a  relative url and appends
http://www.slideshare.net/ to the front if it which then makes

http://www.slideshare.net//cdn.slidesharecdn.com/ss_thumbnails/lptrnhc2008cbnnhtnghththutit360-130902225125-phpapp02-thumbnail-2.jpg

which is an incorrect url and the image will not be found there

Need to alter the code in htdocs/blocktype/externalfeed/lib.php from
/src="(\/[^"]+)"/ to something that doesn't try and update protocol
relative urls

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1219499

Title:
  Some RSS feed channel images are rendered too large in External feeds
  block

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.5 series:
  In Progress
Status in Mahara 1.6 series:
  In Progress
Status in Mahara 1.7 series:
  In Progress

Bug description:
  Some RSS/Atom feeds provide an over-large channel image/logo which
  disrupts display of the External Feed block in a Mahara Page.

  See e.g. this feed link from the BBC
  http://downloads.bbc.co.uk/podcasts/worldservice/digitalp/rss.xml

  Obviously this is an issue with the feed source rather than Mahara per
  se. However,  the suggested solution is to set CSS  max-width style
  attribute and max-height style attributes to the channel image.

  Will simply need, say,  an appropriate CSS class added to htdocs >
  blocktype > externalfeed > theme > raw > feed.tpl and related .css
  entry

  The RSS 2.0 spec defines a max-width of 144px (default 88px) and max-
  height of 400px (default 31px). So, these would be reasonable values.

  http://cyber.law.harvard.edu/rss/rss.html#ltimagegtSubelementOfLtchannelgt

  Thanks
  Geoff

  Mahara version 1.7.2 running on CentOS 6
  Database: MySQL
  Using recent versions of Firefox, Chrome or Opera on Windows 7 or Fedora 19

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1219499/+subscriptions