mahara-contributors team mailing list archive

[Mahara Bot <1160093@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/2452
Committed: http://gitorious.org/mahara/mahara/commit/20512fdb0c485e651fab76dbfc7c2268a30913c7
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 20512fdb0c485e651fab76dbfc7c2268a30913c7
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Mon Aug 26 17:00:38 2013 +1200

Changing PluginAuth API to specifically indicate whether Auth requires
remote username

Bug 1160093: This adds a few new methods to the Auth class, which
represents an auth instance:

- is_parent_authority(): Indicates whether this auth instance is a parent authority or not
- get_parent_authority(): Gets the ID of this auth instance's parent authority
- needs_remote_username(): Indicates whether this auth instance needs the user to have a
remote username setting (in auth_remote_user table)

I've also updated the SAML and XMLRPC auth types, which are the only ones that use remote username.
And I've updated create_user() to automatically populate auth_remote_user() for auth
instances that use it.

Note that an auth instance of ANY type will need a remote username if it's the parent to another
authority (the parent feature allows a user to log in via the parent or the child auth instance;
so it's quite possible for the user to have different usernames in the two of them. Currently
only XMLRPC uses the parent auth feature.)

Lastly, also updated the documentation of LiveUser->create_user() to indicate that it only
uses the $remoteauth parameter as a boolean (which was true even before my code changes).

Change-Id: I39b1b74e68cdbc9c2632b886655caaaece1bd312

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1160093

Title:
  Don't display a remote username on /admin/users/edit.php if no remote
  username exists

Status in Mahara ePortfolio:
  In Progress

Bug description:
  Per default, Mahara displays the "Username for external
  authentication" on the user account admin page no matter whether the
  account has actually set a remoteuser value or not. This is confusing
  when you want to check if an auth instance works correctly because you
  will have to check the database (in 2 different places) or at least do
  a user report which pulls the remotuser value from the "correct" DB
  table.

  Mahara should only display a remoteuser if it really exists.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1160093/+subscriptions