← Back to team overview

mahara-contributors team mailing list archive

[Bug 1221001] A change has been merged

 

Reviewed:  https://reviews.mahara.org/2475
Committed: http://gitorious.org/mahara/mahara/commit/cc1a2812db289e42d10544c19d392ef091406335
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    master

commit cc1a2812db289e42d10544c19d392ef091406335
Author: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>
Date:   Thu Sep 5 15:46:17 2013 +1200

Make Embedded PDF work for logged-out users

Bug 1221001. Needed artefact/lib.php (which apparently gets included by init.php if you're logged in),
and it needed to add &view= to the file download URL so that Mahara could tell which view was giving
you access to the PDF file.

Change-Id: If7c0a6a843588075104819f7ea1e53e392cc4959

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1221001

Title:
  Embedded PDFs don't display to logged-out users

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  I thought I was having problems with embedded PDFs not displaying
  properly in Chromium and FF, but it turns out the problem was that I
  was viewing them while logged in (since I was editing the page) in FF,
  and then to save time I was viewing them while logged out in my other
  browsers.

  To replicate:

  1. Create a page that has an embedded PDF.
  2. Make the page viewable by Public
  3. Log out
  4. View the page (while logged out)

  Expected result: You should be able to see the embedded PDF
  Actual result: You see only the embedded PDF block's title (in FF and Chromium) or the title and a grayed-out scrollbar (in IE).

  So it looks like the problem may be that some of the JS is not getting
  included into the page when a logged-out user views it.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1221001/+subscriptions


References