mahara-contributors team mailing list archive

[Mahara Bot <1204309@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/2479
Committed: http://gitorious.org/mahara/mahara/commit/036d82fb14a12f2f35c202a7e5d278d480541f30
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 036d82fb14a12f2f35c202a7e5d278d480541f30
Author: Nitish Bezzala <nbezzala@xxxxxxxxx>
Date:   Sun Sep 8 05:19:41 2013 -0500

Edit forum post error if parent is deleted (Bug 1204309)

For Edit post, we can use the parent post to get the group or the topic details
even if the parent has the deleted flag set to 1. I am checking that the parent
is not deleted only for add post.

Since the get parent query is common to both add and edit post, I changed it to
search for a parent ignoring the deleted flag.

Change-Id: Ie0602d940d3c3b97e97159f8bfa540128c7f1f1d
Signed-off-by: Nitish Bezzala <nbezzala@xxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1204309

Title:
  Edit forum post error if parent is deleted

Status in Mahara ePortfolio:
  In Progress

Bug description:
  If you have:
  1. a forum post and then
  2. add a child post to it then
  3. add a grandchild post to the child post
  4. add a great-grandchild post to the grandchild post
  5. delete child post

  You now can't edit the grandchild post even though it has an edit
  button because it's 'parent' is deleted.

  The file interaction/forum/editpost.php is the page that throws up the
  error:

     Not found
     The page you are looking for could not be found.

     Could not find post with id 2

  You can however edit the great-grandchild post as it has a viable
  'parent'.

  Either you should be able to edit the child of a deleted parent - or
  you shouldn't be given an edit button if you can't.

  My 2 cents believes you should be able to edit an orphan child as not
  having a parent is irrelevant to the text of the post that the child
  displays.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1204309/+subscriptions