mahara-contributors team mailing list archive

[Mahara Bot <1215190@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/2509
Committed: http://gitorious.org/mahara/mahara/commit/c377ebeeb02bdf44668a86979344a634783187a0
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    1.5_STABLE

commit c377ebeeb02bdf44668a86979344a634783187a0
Author: John Kelsh <jkelsh@xxxxxxxxxxxxxx>
Date:   Thu Sep 12 19:40:03 2013 +1200

LDAP support for LDAP URLs with non-standard ports

Bug 1215190

Change-Id: I9cc40f1a528bd92398b16df833fcaf8aaf314ff7
Signed-off-by: Aaron Wells <aaronw@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1215190

Title:
  LDAP support for non-standard port LDAP Urls

Status in Mahara ePortfolio:
  Fix Committed
Status in Mahara 1.6 series:
  Fix Committed
Status in Mahara 1.7 series:
  Fix Committed
Status in Mahara 1.8 series:
  Fix Committed

Bug description:
  This came up from a user asking for help on IRC. They had upgraded
  their site from Mahara 1.4 to Mahara 1.5 and found that LDAP
  authentication stopped working. Their LDAP "host URL" field was in
  this format: ldap://fake-dc1.fake.ac.uk:3268;

  In Mahara 1.4, this string would be passed in as the first and only
  parameter to ldap_connect().

  In Mahara 1.5, the code is "smarter" and notices the final colon
  before the port number 3268. It strips this off of the URL, and passes
  "ldap://fake-dc1.fake.ac.uk"; as the first parameter and "3268" as the
  second parameter to ldap_connect().

  The problem is, if the first parameter to ldap-connect is in "URL
  style" starting with a protocol ldap:// or ldaps://, ldap_connect()
  IGNORES the second parameter. And so the port was stripped off, and
  then ignored, and the connection didn't work.

  Making matters worse, the documentation tells people to put a protocol
  header on the front of their "Host URL".

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1215190/+subscriptions