mahara-contributors team mailing list archive

[Mahara Bot <1236122@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/2579
Committed: http://gitorious.org/mahara/mahara/commit/2d855e68254839c5695959497ff6e377a8fd0c74
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    master

commit 2d855e68254839c5695959497ff6e377a8fd0c74
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Mon Oct 7 12:49:58 2013 +1300

Problems with image gallery and file/folder selection
Bug 123530 and Bug 1236122

When js slideshow was chosen on a page without a slideshow block
(eg a new page) the js code returned by the selection was not loaded
fast enough

- I've altered it so the js is loaded on opening of config block

- Also folder was not staying selected when re-editing the block
due to it being not ArtefactTypeFile - have adjusted the check to
include ArtefactTypeFolder as well

- The switching between My files and Site files was breaking due to
folder artefact chooser not having certain elements on the page that the
js was trying to access. Have made it so js checks for elements before
trying to update them.

Change-Id: I9b8cbe786b0d35109f05a664f04665e9a9967d92
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1236122

Title:
  "Image gallery" block: switching between "Site files" and "My files"
  closes block config

Status in Mahara ePortfolio:
  In Progress

Bug description:
  To replicate:

  1. Create a page
  2. Drag an "Image Gallery" block onto the page
  3. In the block's configure pop-up, click the "Site files" tab
  4. Now, click back to the "My files" tab.

  Expected result: Should show the "My files" tab's content
  Actual result: It closes the block's config pop-up

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1236122/+subscriptions