mahara-contributors team mailing list archive

[Aaron Wells <1236661@xxxxxxxxxxxxxxxxxx>]

Huh, it looks like we added an (unused) function to the GroupType class,
"public static abstract function get_view_editing_roles()", and a bit of
code in the View constructor that tries to call that function, when
viewing a group page, in order to find out the editingroles for the
group.

This was added as part of https://reviews.mahara.org/#/c/2387/ , the
mega-patch for all the changes to the page builder. But it looks like
it's unnecessary to that code.

So, I'll go ahead and remove it, since it's causing problems. I will
also add a one-time script in the update script to delete orphaned group
pages.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1236661

Title:
  Site statistics: Pages - Page not found error when a page's group has
  been deleted in 1.4, followed by an upgrade to 1.8

Status in Mahara ePortfolio:
  Incomplete
Status in Mahara 1.8 series:
  Incomplete

Bug description:
  If a group has been deleted, the Admin Home/Site Statistics/Pages tab
  (Most Popular Pages) comes up with the error:

  Page not found

  You tried to access a page that does not exist.

  Page with id 0 not found.

  The View construct is trying to load the deleted group but as it is
  deleted, it automatically throws an exception ViewNotFoundException.

  Called in function htdocs/lib/view.php::get_extra_view_info() line
  4124 ($view = new View(0, $v);

  Update: This only occurs when the group was deleted in Mahara 1.4 or
  earlier. After 1.5, the group_delete() function was updated to also
  delete all the group's Pages. And the error on the report page only
  happens in Mahara 1.8, probably due to some change we made in
  View::get_extra_view_info().

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1236661/+subscriptions