← Back to team overview

mahara-contributors team mailing list archive

[Bug 1237013] Re: Allow theme to turn off skins

 

To update this with some discussion we had on IRC -- the skin sylesheet
is a dwoo template, so the theme can override it and "turn skins off"
that way, by making it so that a Page's skin doesn't have any bearing on
how the Page is displayed.

But, this patch is meant to go a bit farther, and also hide the
Portfolio -> Skins page, and the "Skins" tab when editing a Page. In
effect, it's the same as doing $cfg->skins = false;, or of turning skins
off for the user's institution.

I'm somewhat against the feature, because I think there is too much
potential for user confusion in letting Themes turn features on and off.
This would be especially true if the site has user-picked themes turned
on, or page themes turned on. The user changes their theme, and suddenly
they can't find the Portfolio->Skins page anymore.

Or even via Institution themes it could be confusing -- the Institution
admin turns skins on for their Institution, but they unknowingly pick a
Theme that has skins turned off. They wonder, hey, why is there no
Portfolio->Skins page?

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1237013

Title:
  Allow theme to turn off skins

Status in Mahara ePortfolio:
  New

Bug description:
  Say you made a special theme, like a moderator one, where the set of
  things one can access is a subset of all things one can access (eg
  less artefact options) and you thought hey I don't want this theme to
  have access to making/editing/displaying skins.

  So you'd want the theme to be able to turn off skins.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1237013/+subscriptions


References