← Back to team overview

mahara-contributors team mailing list archive

[Bug 1233403] Re: adding custom layout duplication

 

Yeah, you're right. Somehow I missed that bit when reviewing it before.
:)

It still looks like the double-group-by is redundant, but since it's
only checked like once per page load it's not that big of a problem.

** Changed in: mahara
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1233403

Title:
  adding custom layout duplication

Status in Mahara ePortfolio:
  Fix Committed

Bug description:
  In Mahara 1.8 Portfolio -> Pages section

  When I edit the layout for a page and choose the 'create custom
  layout' option I can add a new option that matches existing options. I
  can also add multiple copies of a non existing layout.

  There should be some checking to make sure one is not adding an
  existing option otherwise the available options get quite filled up
  with duplication pretty quickly.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1233403/+subscriptions


References