← Back to team overview

mahara-contributors team mailing list archive

[Bug 1240208] A change has been merged

 

Reviewed:  https://reviews.mahara.org/2612
Committed: http://gitorious.org/mahara/mahara/commit/a640185d7542957161d4d955d960ea1f5146358f
Submitter: Aaron Wells (aaronw@xxxxxxxxxxxxxxx)
Branch:    master

commit a640185d7542957161d4d955d960ea1f5146358f
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Wed Oct 16 08:46:56 2013 +1300

Having 2 favourite skins broke add skin to page (bug 1240208)

the db call was complaining about ERROR: invalid input syntax for
integer: "2,3"

so I adjusted the db call to be similar to other WHERE id IN ( )
calls used elsewhere.

Change-Id: I65eb82e659d51cf08ef29d8c37b5bd4b312a2fa1
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1240208

Title:
  unable to have multiple favourite skins

Status in Mahara ePortfolio:
  In Progress

Bug description:
  If you have more than one favourite skin you are not able to choose a
  skin for a page any more.

  [WAR] 92 (lib/errors.php:752) Failed to get a recordset: postgres7 error: [-1: ERROR:  invalid input syntax for integer: "2,3"] in EXECUTE("SELECT s.id, s.title, s.owner, s.type
                  FROM "skin" s
                  WHERE s.id IN (?)
                  ORDER BY s.title, s.id")
  Command was: SELECT s.id, s.title, s.owner, s.type
                  FROM "skin" s
                  WHERE s.id IN (?)
                  ORDER BY s.title, s.id and values was (2,3)
  Call stack (most recent first):

      log_message("Failed to get a recordset: postgres7 error: [-1: E...", 8, true, true) at /home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/errors.php:109
      log_warn("Failed to get a recordset: postgres7 error: [-1: E...") at /home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/errors.php:752
      SQLException->__construct("Failed to get a recordset: postgres7 error: [-1: E...") at /home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/dml.php:492
      get_recordset_sql("SELECT s.id, s.title, s.owner, s.type ...", array(size 1), "", "") at /home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/dml.php:675
      get_records_sql_array("SELECT s.id, s.title, s.owner, s.type ...", array(size 1)) at /home/robertl/htdocs/mahara-devel/mahara/htdocs/lib/skin.php:443
      Skin::get_favorite_skins() at /home/robertl/htdocs/mahara-devel/mahara/htdocs/view/skin.php:58

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1240208/+subscriptions


References