mahara-contributors team mailing list archive

[Aaron Wells <1236661@xxxxxxxxxxxxxxxxxx>]

Patch 2606 was merged into 1.8rc2. But since then, we've found that the
one-time script that goes through and deletes orphaned group pages,
needs some work.

The problem is, that since there's no way to tell which groups were
deleted prior to 1.5, it cycles through every deleted group, and runs
the group_delete() method for it. In the case of an old/large site, this
can take a really long time.

Additionally, running group_delete() a second time causes the group
names to get re-munged. When you delete it the first time it's changed
to something like "deleted.$name.$timestamp". If you call group_delete()
on the same group a second time, it becomes something like
"deleted.deleted.$name.$timestamp.$timestamp". And this was long enough,
in the case of some groups, that it caused the update to fail because
the name was too long to fit into the table column.

So both of those issues need to be fixed for 1.8.0

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1236661

Title:
  Site statistics: Pages - Page not found error when a page's group has
  been deleted in 1.4, followed by an upgrade to 1.8

Status in Mahara ePortfolio:
  In Progress
Status in Mahara 1.8 series:
  In Progress

Bug description:
  If a group has been deleted, the Admin Home/Site Statistics/Pages tab
  (Most Popular Pages) comes up with the error:

  Page not found

  You tried to access a page that does not exist.

  Page with id 0 not found.

  The View construct is trying to load the deleted group but as it is
  deleted, it automatically throws an exception ViewNotFoundException.

  Called in function htdocs/lib/view.php::get_extra_view_info() line
  4124 ($view = new View(0, $v);

  Update: This only occurs when the group was deleted in Mahara 1.4 or
  earlier. After 1.5, the group_delete() function was updated to also
  delete all the group's Pages. And the error on the report page only
  happens in Mahara 1.8, probably due to some change we made in
  View::get_extra_view_info().

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1236661/+subscriptions