mahara-contributors team mailing list archive

[Mahara Bot <1240415@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/2618
Committed: http://gitorious.org/mahara/mahara/commit/6ab0c9f9ab4b03a0e769351d5ec2b815ad688648
Submitter: Robert Lyon (robertl@xxxxxxxxxxxxxxx)
Branch:    master

commit 6ab0c9f9ab4b03a0e769351d5ec2b815ad688648
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Thu Oct 17 11:37:56 2013 +1300

Allowing file browser to stay open when changing dirs (bug 1240415)

Problems here is there are 2 file pickers on the same form so we can't
use the normal js success callback to update form so we have to go the
non js way - but if we have browse=1 in the url the form won't save.

Patch looks to see if folder is set in url and if so then we
are in a browse mode.

Also adjusted the template to allow for the adding of the 'select
a file' button (in hidden state) to the page when entering the
subdirectories. this will mean the hidden button will be added to a few
places where it is not need (eg selecting an image gallery
blockinstance) but as it is hidden by default no one will see it.

A better fix would be to get multiple filechooser elements working in one form
but this isn't likely to happen at the moment.

Change-Id: Iddbd677a81d216f71cdeae86a02ed107261c04b5
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1240415

Title:
  Selecting image file for skins is 'jumpy'

Status in Mahara ePortfolio:
  In Progress

Bug description:
  When adding a background image to a skin (testing on Mahara Dev), the file selection window closes each time you change location - to recreate this put a file inside a nested folder (rather than at root level) - eg root/images/skins/skin.jpg - you have to click several times to get to the image as each time you navigate to a new level the interface drops you back at 'select a file' (but remembers the last place you reached and opens the correct folder).
  Adding an image to a page works as normal, so as far as I can tell this seems to be affecting just the fie picker for the skin images.
  Thanks, Gordon.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1240415/+subscriptions