mahara-contributors team mailing list archive

[Mahara Bot <1239539@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://reviews.mahara.org/2610
Committed: http://gitorious.org/mahara/mahara/commit/bf3d14a3949a203a9d37e1152bc1a1129357bfcd
Submitter: Son Nguyen (son.nguyen@xxxxxxxxxxxxxxx)
Branch:    master

commit bf3d14a3949a203a9d37e1152bc1a1129357bfcd
Author: Robert Lyon <robertl@xxxxxxxxxxxxxxx>
Date:   Tue Oct 15 07:51:18 2013 +1300

Allowing pieform error text to not be escaped if needed (Bug 1239539)

Currently if there is html in an error message used by pieforms it
escapes the html so the link becomes not usable.

I have made a change where you can tell pieforms not to escape the
error message.

So instead of using:
$form->set_error($field, $message);

you can use:
$form->set_error($field, $message, false);

Where false means do not escape the message.

As the terms and conditions are displayed on the page already I've
updated the link to jump to the terms section

Change-Id: Ia8650a9f2284fb007cbe81a4a94223f127c4f6cd
Signed-off-by: Robert Lyon <robertl@xxxxxxxxxxxxxxx>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1239539

Title:
  Registration: Force Terms and Conditions - error text

Status in Mahara ePortfolio:
  In Progress
Status in Mahara 1.6 series:
  New
Status in Mahara 1.7 series:
  New

Bug description:
  This is quite minor but I wanted to make a note of it somewhere.

  When the user registers and are forced to accept the terms and
  conditions, the required error message that appears when they submit
  the form (without accepting the terms) comes up with:

  You may not register unless you agree to abide by the <a
  href="terms.php">Terms and Conditions</a>.

  with the raw html code for the link to the terms.php.  It doesn't
  actually render the link.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1239539/+subscriptions