mahara-contributors team mailing list archive

[Robert Lyon <robertl@xxxxxxxxxxxxxxx>]

have added a patch for this:
https://reviews.mahara.org/#/c/2668/

Things to note:
1) The feedback block is only to display view's comments on the
view/view.php page and NOT on view/artefact.php page.

2) When in edit mode (view/blocks.php) the feedback block just
displays a 'holder' message

3) When feedback block is on page the feedback does not display at
base of page anymore and when one clicks the 'Place feedback' link the
feedback form pops up over everything similar to how editing a block
works.

4) As the feedback block only works/displays on the view page I have
not fully integrated all the stuff that feedback creates ie js/form
into the blocktype. I have left the view/view.php to do the js and
render form - and simply position the form on the page with js.

This means that if js is off the edit form will still be in it's
old place. I felt this was ok because if js is off and the form was
in the block it could mean things been too squashy if there was lots
of columns.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1245679

Title:
  Place feedback for a view in a block rather at base of page

Status in Mahara ePortfolio:
  In Progress

Bug description:
  Feedback for a page can currently only be placed at the bottom of a
  page.

  However, it would be useful if feedback could be placed elsewhere.

  It would be good to have a comment blocktype allowing one to add a
  comment block to a page making the feedback display in the block's
  position rather than at the base of the page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1245679/+subscriptions